change whitelist_externals to allowlist_externals to fix broken tox config #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, the 3.8 and Windows CI runs still fail for some reason. |
|
Thanks. |
|
I might open another draft PR and continue poking around to see why the other CIs are still failing. Looks like the 3.8 ones might be a poetry version mismatch, but I'm not sure what's wrong with windows. |
|
I don't have access to a Windows machine so I can't really debug (and shouldn't have added the windows build in the first place). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the CI was failing because
toxnow expects aallowlist_externalskey instead of awhitelist_externalskey.