Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass 0 to let go parse the base value #229

Merged
merged 1 commit into from
Dec 18, 2023
Merged

pass 0 to let go parse the base value #229

merged 1 commit into from
Dec 18, 2023

Conversation

abice
Copy link
Owner

@abice abice commented Dec 18, 2023

Improves upon #219 by letting go parse the base from the string instead of adding logic to do it separately.

Fixes #219

@coveralls
Copy link

Coverage Status

coverage: 92.27% (-0.3%) from 92.55%
when pulling 9a3d7ff on abice/parsebases
into f2bc4fe on master.

@abice abice merged commit 28240c6 into master Dec 18, 2023
4 checks passed
@abice abice deleted the abice/parsebases branch December 18, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants