Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stock News Sentiment Analysis #454

Merged

Conversation

Shobhit-Bandhu
Copy link
Contributor

Pull Request for ML-Crate 💡

Issue Title: Stock News Sentiment Analysis #351

  • Info about the related issue (Aim of the project) :
  • Name: Shobhit-Bandhu
  • GitHub ID: Shobhit-Bandhu
  • Idenitfy yourself: Contributor KWOC '23

Closes: #351

Describe the add-ons or changes you've made 📃

Preprocessed data, added SVM model.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @Shobhit-Bandhu :)

@Shobhit-Bandhu Shobhit-Bandhu marked this pull request as ready for review December 19, 2023 12:23
@abhisheks008
Copy link
Owner

Please complete the whole project and update the blanks in the Jupyter Notebook and README.md. Once you are done with this, do let me know.

(Failed due to uncapable hardware on both native gpu, colab and kaggle despite simple model)
(Failed due to uncapable hardware on both native gpu, colab and kaggle)
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check out the errors of Tensorflow modelling and try impose it properly.

@@ -0,0 +1,2 @@
# Stock News Sentiment Analysis
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the README.md template and update it accordingly. Here is the template, https://github.com/abhisheks008/ML-Crate/blob/main/.github/readme_template.md

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Dec 22, 2023
@abhisheks008
Copy link
Owner

Hi @Shobhit-Bandhu I have seen that CNNs are not properly implemented in your project, you can remove it from the notebook.

@abhisheks008
Copy link
Owner

Hey @Shobhit-Bandhu your implemented models are not even having accuracy score of 80 atleast. Please upgrade the models and try to achieve an accuracy of atleast 80%.

@Shobhit-Bandhu
Copy link
Contributor Author

@abhisheks008 Any suggestions? Should I use BERT models?

@abhisheks008
Copy link
Owner

@abhisheks008 Any suggestions? Should I use BERT models?

Yeah you can try that.

@Shobhit-Bandhu
Copy link
Contributor Author

@abhisheks008 I can't seem to do better than 54%...

@abhisheks008 abhisheks008 changed the title Stock news sentiment analysis Stock News Sentiment Analysis Jan 1, 2024
@abhisheks008
Copy link
Owner

Hi @Shobhit-Bandhu sorry for the delay, as I was in vacation. Can you please update the README.md file with the newly added model's accuracy score.

@Shobhit-Bandhu
Copy link
Contributor Author

@abhisheks008 Anything else you would like added?

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Your PR is approved and ready to be merged.
@Shobhit-Bandhu

@abhisheks008 abhisheks008 added Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023 and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Jan 2, 2024
@abhisheks008 abhisheks008 merged commit 2149702 into abhisheks008:main Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✅ This PR is approved by the PR or, Mentors. KWOC 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stock News Sentiment Analysis
2 participants