Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landmark Detection from images #906

Closed

Conversation

yashksaini-coder
Copy link

Pull Request for DL-Simplified 💡

Issue Title : Landmark Detection Project

  • Info about the related issue (Aim of the project) : To add a Landmark detect ML model web app using streamlit
  • Name: Yash K. Saini
  • GitHub ID: yashksaini-coder
  • Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a JWOC 2022 participant it's, JWOC Participant) GSSOC-ext

Closes: #898

Describe the add-ons or changes you've made 📃

This pull request introduces a new feature for landmark detection and includes the necessary setup for a Streamlit web application. The most important changes involve adding a new README file, implementing the main application logic in app.py, and updating the requirements.

New feature implementation:

  • Landmark-Detection/app.py: Added the main application logic for the Landmark Detection web app, including model loading, image classification, and Streamlit UI components.

Documentation:

Dependencies:

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

@abhisheks008 can you review this PR and add labels to it.

Copy link

Our team will soon review your PR. Thanks @yashksaini-coder :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Project folder name should be Landmark Detection with no hyphen "-".
  2. Follow the project structure and put the files according to that.
  3. If you are implementing an UI for the users, follow this project structure, this will help you out in keeping files.
Project Folder
|- Dataset
   |- dataset.csv (dataset used for the particula project)
   |- README.md (brief about the dataset)
|- Images
   |- img1.png
   |- img2.png
   |- img3.png
|- Model
   |- project_folder.ipynb
   |- README.md
|- Web App
   |- templates
   |- static
   |- app.py
   |- demo.mp4
   |- README.md
|- requirements.txt

@yashksaini-coder
Copy link
Author

Hi @abhisheks008 I have restructured the entire Landmark Detection folder as per your requests

image


Review the PR & add labels to it.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a demonstration video of the working of the UI and attach the same in the Web App/README.md file.

For your reference you can check this project, https://github.com/abhisheks008/DL-Simplified/tree/main/Brain%20Tumor%20Detection/Web%20App

@yashksaini-coder
Copy link
Author

Hi @abhisheks008 here's the demo video of Landmark Detection

Landmark.detection.mp4

@yashksaini-coder
Copy link
Author

@abhisheks008 can you review this PR, add proper labels too.

@yashksaini-coder
Copy link
Author

@abhisheks008 what's the status of the review.

@abhisheks008
Copy link
Owner

  1. Project folder name should be Landmark Detection with no hyphen "-".
  2. Follow the project structure and put the files according to that.
  3. If you are implementing an UI for the users, follow this project structure, this will help you out in keeping files.
Project Folder
|- Dataset
   |- dataset.csv (dataset used for the particula project)
   |- README.md (brief about the dataset)
|- Images
   |- img1.png
   |- img2.png
   |- img3.png
|- Model
   |- project_folder.ipynb
   |- README.md
|- Web App
   |- templates
   |- static
   |- app.py
   |- demo.mp4
   |- README.md
|- requirements.txt

@yashksaini-coder please follow the project structure properly. Do not put files apart from the designated folder.

Model/README.md template: https://github.com/abhisheks008/DL-Simplified/blob/main/.github/readme_template.md
Web App/README.md template: https://github.com/abhisheks008/DL-Simplified/blob/main/.github/web-app_readme_template.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Landmark Detection Project
2 participants