-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stock Analysis #896
Stock Analysis #896
Conversation
Our team will soon review your PR. Thanks @Itachii27 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Itachii27 your model implementation looks good to me. Need some minor changes/updation in the README file. Follow the template and update the README file accordingly.
Here is the template, https://github.com/abhisheks008/DL-Simplified/blob/main/.github/readme_template.md
Hi @abhisheks008 I have done the changes as requested. Please review the PR again |
Hi @abhisheks008 I have done the changes. Please review the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Your PR is approved and ready to be merged.
@Itachii27
Pull Request for DL-Simplified 💡
Issue Title : Stock Analysis #893
Closes: #893
Describe the add-ons or changes you've made 📃
Give a clear description of what have you added or modifications made
Type of change ☑️
What sort of change have you made:
How Has This Been Tested? ⚙️
Describe how it has been tested
Describe how have you verified the changes made
Checklist: ☑️