Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project Addition]: Real Time Sudoku Solver #799

Merged
merged 12 commits into from
Jun 16, 2024

Conversation

abckhush
Copy link
Contributor

Pull Request for DL-Simplified 💡

Issue Title : [Project Addition] :Real Time Sudoku Solver Using OpenCV

  • Info about the related issue (Aim of the project) :
  • Name: Khushi Kalra
  • GitHub ID:abckhush
  • Email ID: [email protected]
  • Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a JWOC 2022 participant it's, JWOC Participant) GSSoC 2024 Contributor

Closes: #774

Describe the add-ons or changes you've made 📃

added Real time Sudoku solver.

Type of change ☑️

What sort of change have you made:

  • New feature (non-breaking change which adds functionality

How Has This Been Tested? ⚙️

Yes, A sample demonstration video is included in the README.md file

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @abckhush :)

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the project structure and put the files as per the project structure.

For your reference check out the existing projects and update the structure of the project.

@abckhush

@abhisheks008 abhisheks008 added Status: Requested Changes Changes requested. gssoc Girlscript Summer of Code 2024 labels Jun 15, 2024
@abckhush
Copy link
Contributor Author

Hi @abhisheks008. I have made the desired changes. Kindly check.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the README template and update the same.

Template: https://github.com/abhisheks008/DL-Simplified/blob/main/.github/readme_template.md

@abckhush
Copy link
Contributor Author

Models Implemented
Exploratory Data Analysis Results
Performance of the Models based on the Accuracy Scores
These do not apply for my project/

@abhisheks008
Copy link
Owner

Models Implemented Exploratory Data Analysis Results Performance of the Models based on the Accuracy Scores These do not apply for my project/

Brief your project and add the images in the README to demonstrate the process how it works.

@abckhush
Copy link
Contributor Author

I have updated the readme file as per requirements. The images are already present in the Images folder. Do you want me to change anything else?

@abhisheks008 abhisheks008 changed the title added Real Time Sudoku Solver [Project Addition]: Real Time Sudoku Solver Jun 16, 2024
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Approved @abckhush

@abhisheks008 abhisheks008 added Status: Approved Approved PR by the PA. level 2 Level 2 for GSSOC and removed Status: Requested Changes Changes requested. labels Jun 16, 2024
@abhisheks008 abhisheks008 merged commit 39e42a9 into abhisheks008:main Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girlscript Summer of Code 2024 level 2 Level 2 for GSSOC Points Updated Status: Approved Approved PR by the PA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project Addition] :Real Time Sudoku Solver Using OpenCV
2 participants