Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to node16 #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christoph-schauppel
Copy link

No description provided.

@pako-grape
Copy link

Hello @abhilash1in, is anything blocking the merge? Looks like an easy fix for the annoying node12 deprecation warning ;)

@ali-kafel
Copy link

@abhilash1in I approve/bump this change as well.

@aakilin
Copy link

aakilin commented Oct 26, 2023

@ali-kafel could you finally merge the PR? Or is there a way to use the GitHub actions without annoying

build (dev, backend, mediaplanner-0) / build

The following actions uses node12 which is deprecated and will be forced to run on node16: abhilash1in/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

@ali-kafel
Copy link

@aakilin I ended up switching to this action: https://github.com/aws-actions/aws-secretsmanager-get-secrets

It does the exact same thing and is an official action from aws that is properly maintained unlike this repo.

@aakilin
Copy link

aakilin commented Oct 26, 2023

@ali-kafel thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants