Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option --no-bbox to the layout command #682

Merged
merged 4 commits into from
Jan 7, 2024
Merged

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Jan 7, 2024

Description

Added option --no-bbox to the layout command to use the pre-existing page size instead of the geometry bounding box for layout

Checklist

  • feature/fix implemented
  • code formatting ok (black and ruff check .)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

abey79 added 2 commits January 7, 2024 17:39
Added option `--no-bbox` to the `layout` command to use the pre-existing page size instead of the geometry bounding box for layout
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9cb78f) 94.67% compared to head (35a3415) 94.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   94.67%   94.71%   +0.04%     
==========================================
  Files          62       62              
  Lines        5746     5756      +10     
  Branches     1269     1272       +3     
==========================================
+ Hits         5440     5452      +12     
+ Misses        188      187       -1     
+ Partials      118      117       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jan 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@abey79 abey79 merged commit 9ee611f into master Jan 7, 2024
14 checks passed
@abey79 abey79 deleted the layout-no-bbox-663 branch January 7, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for layout arg to maintain size of svg element
1 participant