Extract send_magic_link out to a method #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep makes sense to me! Could you replace the |
I've extracted the code to send the magic link out to it's own method, which allows it to be overridden in other apps using this gem if they want to perform additional actions when the email is sent successfully. This can already be done using the `send_magic_link` method on the "user" model, but sometimes the logic you want to add doesn't make sense in the model layer.
|
@abevoelker Great, thank you! I've rebased it now |
|
Hey @abevoelker sorry for the nudge, but is there any chance of getting this merged and released? 🙏 |
|
@iainbeeston Don't be sorry! Released now as 1.0.3. Thanks for your contrib! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've extracted the code to send the magic link out to it's own method, which allows it to be overridden in other apps using this gem if they want to perform additional actions when the email is sent successfully. One of the strengths of devise is having overridable methods like this, so I feel that it's in-keeping with how other devise controllers work.
This can already be done using the
send_magic_linkmethod on the "user" model, but sometimes the logic you want to add doesn't make sense in the model layer. In my case I'd like to add additional tracking (similar to the trackable devise module) which requires access to the request object.