Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate GrantKit before running terraform plan or apply #44

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Validate GrantKit before running terraform plan or apply #44

merged 2 commits into from
Apr 1, 2024

Conversation

songe
Copy link
Contributor

@songe songe commented Apr 1, 2024 •
edited
Loading

What

  • Validate GrantKit before running terraform plan or apply
    • by adding ModifyPlan function
  • Include liblab_tf_provider go build tag in .goreleaser.yml
  • Bump up version to 0.2.9

Why

To support validation during planning phase

Checklist & Testing

Does this change require any testing?
An example of some testing to do:

  • : make test

Deploy Steps

Does this change require any special deploy steps?

  • git tag -v v0.2.9
  • git push origin v0.2.9

@songe songe requested a review from a team as a code owner April 1, 2024 17:24
@jeffchao
Copy link
Contributor

jeffchao commented Apr 1, 2024

@songe tests failing?

@songe
Copy link
Contributor Author

songe commented Apr 1, 2024

@songe tests failing?

@jeffchao Fixed

@songe songe merged commit 7ca90be into main Apr 1, 2024
5 checks passed
@songe songe deleted the angie/validate-plan branch April 1, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchao jeffchao jeffchao approved these changes

Assignees

@songe songe

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@songe @jeffchao