Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace in_group with member_of. #4

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Replace in_group with member_of. #4

merged 2 commits into from
Jan 13, 2024

Conversation

jeffchao
Copy link
Contributor

Replace in_group with member_of.

@jeffchao
Copy link
Contributor Author

jeffchao commented Jan 12, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@jeffchao jeffchao mentioned this pull request Jan 12, 2024
Merged
@jeffchao jeffchao self-assigned this Jan 12, 2024
@jeffchao jeffchao requested a review from a team January 12, 2024 02:06
@jeffchao jeffchao force-pushed the jeff/member-of-2 branch 2 times, most recently from 79777bb to f2a4688 Compare January 12, 2024 02:09
songe
songe reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@songe songe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Curious, it possible to make one an alias of the other?

@jeffchao
Copy link
Contributor Author

jeffchao commented Jan 12, 2024 •
edited
Loading

Definitely possible (and easy!). Let's keep a single API for now though.

@jeffchao
Copy link
Contributor Author

jeffchao commented Jan 13, 2024 •
edited
Loading

Merge activity

Base automatically changed from jeff/member-of to main January 13, 2024 00:57
@jeffchao jeffchao merged commit d553b4f into main Jan 13, 2024
2 checks passed
@jeffchao jeffchao deleted the jeff/member-of-2 branch January 13, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songe songe songe left review comments

@hatim-khan hatim-khan hatim-khan approved these changes

Assignees

@jeffchao jeffchao

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffchao @songe @hatim-khan