wip

aaxelb · Aug 16, 2024 · eac2c1d · eac2c1d
1 parent 5566153
commit eac2c1d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/tests/share/bin/test_sharectl.py b/tests/share/bin/test_sharectl.py
@@ -8,7 +8,7 @@
 from share.bin.util import execute_cmd
 import share.version
 
-from tests.share.search._testutil import patch_index_strategies
+from tests.share.search import patch_index_strategies
 
 
 def run_sharectl(*args):

diff --git a/tests/share/search/_testutil.py → tests/share/search/__init__.py b/tests/share/search/_testutil.py → tests/share/search/__init__.py
@@ -1,9 +1,7 @@
 import contextlib
-import typing
 from unittest import mock
 
-if typing.TYPE_CHECKING:
-    from share.search import index_strategy
+from share.search import index_strategy
 
 
 @contextlib.contextmanager

diff --git a/tests/share/search/conftest.py b/tests/share/search/conftest.py
@@ -5,6 +5,7 @@
 
 @pytest.fixture
 def mock_elastic_clients(settings):
+    # set elastic urls to non-empty but non-usable values
     settings.ELASTICSEARCH5_URL = 'fake://bleh'
     settings.ELASTICSEARCH8_URL = 'fake://bluh'
     with mock.patch('share.search.index_strategy.sharev2_elastic5.elasticsearch5'):