friendlier FeatureFlag admin list

aaxelb · Oct 12, 2023 · 5a15ece · 5a15ece
1 parent fd3969d
commit 5a15ece
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/share/admin/__init__.py b/share/admin/__init__.py
@@ -333,6 +333,7 @@ def reset_to_initial(self, request, queryset):
 class FeatureFlagAdmin(admin.ModelAdmin):
     readonly_fields = ('name',)
     search_fields = ('name',)
+    list_display = ('name', 'is_up', 'is_defined')
 
 
 admin_site.register(AccessToken, AccessTokenAdmin)

diff --git a/share/models/feature_flag.py b/share/models/feature_flag.py
@@ -26,7 +26,7 @@ def _flag_cache_key(self, flag_name) -> str:
 
 
 class FeatureFlag(models.Model):
-    # flag name constants:
+    # flag name constants
     ELASTIC_EIGHT_DEFAULT = 'elastic_eight_default'
     IGNORE_SHAREV2_INGEST = 'ignore_sharev2_ingest'
     SUGGEST_CREATOR_FACET = 'suggest_creator_facet'
@@ -41,3 +41,7 @@ def __repr__(self):
         return f'{self.__class__.__name__}(name="{self.name}", is_up={self.is_up})'
 
     __str__ = __repr__
+
+    @property
+    def is_defined(self):
+        return self.name.lower() == getattr(FeatureFlag, self.name.upper(), None)