ArrayNodeDeserializer can now deserialize circular references. #937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #933
The
ArrayNodeDeserializer
delegates the deserialization of elements to theCollectionNodeDeserializer.DeserializeHelper
. This, in turn, handles circular references by relying on theIValuePromise.ValueAvailable
event to write all the resolved references to itsIList result
parameter.However, because
ArrayNodeDeserializer
doesn't know the size of its resulting array beforehand, it uses a temporaryArrayList
which it passes toCollectionNodeDeserializer.DeserializeHelper
. As a result, all resolved ValuePromise values are written to the temporaryArrayList
instead of the finalArray
.This PR fixes this by adding an optional
Action<int, object?>? promiseResolvedHandler
toCollectionNodeDeserializer.DeserializeHelper
. When provided, it is used when ValuePromises are resolved. Otherwise, the existing behaviour is preserved.