You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I'm not using a formatter I still have my own set of rules I usually follow and the formatter you used does not follow them. That is a change I don't want, if I decide to change formatting I will do it myself. And while it is nice that you added translations, they are currently not used inside the plugin. However I would merge a PR changing nothing but the translations file in case I will add translations again. It would probably use a few different messages but I should still be able to use several of the already existing translations.
While I'm not using a formatter I still have my own set of rules I usually follow and the formatter you used does not follow them. That is a change I don't want, if I decide to change formatting I will do it myself. And while it is nice that you added translations, they are currently not used inside the plugin. However I would merge a PR changing nothing but the translations file in case I will add translations again. It would probably use a few different messages but I should still be able to use several of the already existing translations.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 1 language and made the code easier to read