Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.1.2 #22

Merged
merged 14 commits into from
Nov 21, 2023
Merged

Version 1.1.2 #22

merged 14 commits into from
Nov 21, 2023

Conversation

MatteoCampinoti94
Copy link
Member

@MatteoCampinoti94 MatteoCampinoti94 commented Nov 21, 2023 •
edited
Loading

Reference Files

  • Get reference files from latest release instead of directly using the main branch
  • Errors in the request now raise HTTPError instead of HTTPException

Utils

Helpers

  • ExceptionManager can now be set to allow some exceptions to rise
    • If an exception's type is explicitly declared in the 'catch' argument, then it is always caught even if its subclass should be let through

@MatteoCampinoti94
reference_files - use release URL to download files
ce2e99e
@MatteoCampinoti94
reference_files - rename ref_files.py to get.py
36de32b
@MatteoCampinoti94
reference_files - cached download functions get URL from parameters
0062ba2 
Avoids cache overriding changes to the URL
@MatteoCampinoti94
reference_files - raise HTTPError instead of HTTPException
61e8141 
Consistent with built-in behaviour of urlopen, which raises HTTPError automatically on 404 responses.
@MatteoCampinoti94
reference_files - update docstrings with Raises
5f4455b
@MatteoCampinoti94
reference_files - import urlopen directly
0eb9d3e
@MatteoCampinoti94
tests:reference_files - test error
953ee98
@MatteoCampinoti94
utils:helpers - let ExceptionManager raise specific exceptions
66f526f
@MatteoCampinoti94
tests:utils - test allow argument of ExceptionManager
fa89e5d
@MatteoCampinoti94
utils:helpers - ExceptionManager always catches explicitly declared e…
011c096 
…xceptions
@MatteoCampinoti94
tests:utils - update ExceptionManager tests
cf67268
@MatteoCampinoti94
utils:helpers - update ExceptionManager docstring
db1cdc8 
Describe behaviour of exceptions whose class is declared in `catch` but whose subclass(es) is in `allow`.
@MatteoCampinoti94
version - patch 1.1.1 > 1.1.2
53db8a7
@MatteoCampinoti94
poetry - version patch 1.1.1 > 1.1.2
4de5e0d
@MatteoCampinoti94 MatteoCampinoti94 self-assigned this Nov 21, 2023
@MatteoCampinoti94 MatteoCampinoti94 merged commit bff3199 into main Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clausjuhl clausjuhl clausjuhl approved these changes

Assignees

@MatteoCampinoti94 MatteoCampinoti94

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatteoCampinoti94 @clausjuhl