added the file extension to the ExtractAction model, since this data i used by renamer and it is for most files also data that we ahve in the fileformats.yml #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i used by renamer and it is for most files also data that we ahve in the fileformats.yml
Magniler
force-pushed
the
add-suffix-to-extract-action
branch
from
09ea065 to
2b075c2
Compare
|
I'd say to change the attribute to just "extension". It's already deep inside the File object ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some functionality that Unarchiver requires.
Some of the tools we use to unpack certain fileformats are very strict as to what file extensions the files that they work with can have, so we need to update the filles which have the wrong extensions