added functionality to run and use siegfried #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also added functions to get info from reference files * Updated the docstring for several of the new functions * Decomposed the new functions into multiple helper functions to avoid duplicate code
This reverts commit 2a6f926.
…adsarkiv/acacore into add-siegfried_functions
added 3 commits
October 17, 2023 09:29
…on main: Now only the methods that handled aca identification remain and they have been moved to the file class. * Also added datamodels to check the data we get from reference files
|
Updated the PR based on the comments left by @MatteoCampinoti94, it is more integrated into the rest of the core functionality |
MatteoCampinoti94
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added functions to get info from reference files
Updated the docstring for several of the new functions
Decomposed the new functions into multiple helper functions to avoid duplicate code