Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for forge-std assert cheatcodes #323

Merged
merged 26 commits into from
Jul 18, 2024
Merged

Conversation

daejunpark
Copy link
Collaborator

@daejunpark daejunpark commented Jun 29, 2024

based on: #306

not yet supported: (to be added in a separate pr)

  • assertEq for bytes[]
  • assertEqDecimal

won't support: (symbolically approximate comparison is too challenging)

  • assertApproxEq

@daejunpark daejunpark changed the title feat: support assert cheatcodes for static values feat: support for forge-std assert cheatcodes Jun 29, 2024
@daejunpark daejunpark requested a review from karmacoma-eth July 18, 2024 05:32
@daejunpark daejunpark merged commit 486f381 into main Jul 18, 2024
73 checks passed
@daejunpark daejunpark deleted the feat/assertEq branch July 18, 2024 05:44
@karmacoma-eth
Copy link
Collaborator

amazing work, thanks @EmperorOrokuSaki and @daejunpark !

pcaversaccio added a commit to pcaversaccio/snekmate that referenced this pull request Jul 31, 2024
### 🕓 Changelog

The `halmos` PR [#323](a16z/halmos#323)
introduced support for the `forge-std` `assert`
[cheatcodes](https://book.getfoundry.sh/forge/cheatcodes). Consequently,
we refactor all existing `halmos` tests to utilise the latest
`forge-std` `assert` cheatcodes. Furthermore, I also update
`pnpm-lock.yaml` and all outdated submodules.

---------
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants