Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run workflow using solvers as a base image #307

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Conversation

karmacoma-eth
Copy link
Collaborator

Example run:
https://github.com/a16z/halmos/actions/runs/9409762438

This works at least as a proof of concept. We should be able to optimize the 1min "build image step" a little bit more:

  • since we want to keep the solvers package very minimal, we need to add the other dependencies we need in CI for halmos (git, python, foundry, etc)
  • we need to checkout the current halmos from github and install it

It would be faster to use either an already published halmos:latest image (but wouldn't help for running tests on a branch).

Alternatively we could also publish an intermediary halmos-base image that already includes git, python, foundry, uv, etc. and we would only need to install the halmos checkout.

@karmacoma-eth
Copy link
Collaborator Author

(note: this PR does not yet enable publishing the halmos package, will do separately)

@daejunpark
Copy link
Collaborator

i ran again the test-ffi but it kept failing. do you have any idea?

@karmacoma-eth
Copy link
Collaborator Author

i ran again the test-ffi but it kept failing. do you have any idea?

weird, 404 trying to download foundry. Maybe now is a good time to switch test-ffi to the docker image too, since it doesn't rely on downloading the github release :)

@karmacoma-eth karmacoma-eth merged commit 4d2161f into main Jun 7, 2024
61 checks passed
@karmacoma-eth karmacoma-eth deleted the use-solvers-image branch June 7, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants