feat: solvers package #302
Conversation
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - feat-packages |
There was a problem hiding this comment.
this is needed until the workflow is merged to main, can't manually dispatch from a branch
| run: docker build . --file packages/solvers/Dockerfile --tag $IMAGE_NAME --label "runnumber=${GITHUB_RUN_ID}" | ||
|
|
||
| - name: Log in to registry | ||
| run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin |
There was a problem hiding this comment.
@mattg-a16z just to double check, do you have any security concerns with this authentication method?
|
@pillip do you have any feedback on this docker file and publishing method? |
packages/solvers/Dockerfile
Outdated
| # Install Yices from the release binaries | ||
| WORKDIR /yices | ||
| ARG YICES_VERSION=2.6.4 | ||
| RUN wget https://github.com/SRI-CSL/yices2/releases/download/Yices-2.6.4/yices-${YICES_VERSION}-x86_64-pc-linux-gnu.tar.gz -O yices.tar.gz && \ |
There was a problem hiding this comment.
nit :
I suggest changing the wget URL address to https://github.com/SRI-CSL/yices2/releases/download/Yices-${YICES_VERSION}/yices-${YICES_VERSION}-x86_64-pc-linux-gnu.tar.gz
for simplify the process of upgrading or modifying the version of Yices
There was a problem hiding this comment.
ah you're right I missed a spot
| rm -rf /boolector | ||
|
|
||
| # Create the final image | ||
| FROM ubuntu:24.04 |
There was a problem hiding this comment.
nit:
Is there a specific reason for using different Ubuntu versions between the final image and the builder?
If there is no specific reason, it would be better to unify them. This can help streamline the build process and reduce potential compatibility issues.
There was a problem hiding this comment.
I wasn't able to build yices on 24.04, but since we moved to binary releases it should be fine. I'll unify on 24.04
Co-authored-by: PILLIP YOUN <[email protected]>
a minimalist Docker image with a few high perf SMT solvers ready to go