-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use configargparse to process halmos.toml #297
Conversation
could you explain in which order options are applied? we now have four sources of options:
i think the above order makes sense. wdyt? |
what's the semantics of sections? can we have multiple sections in a toml file, and choose which section to use when running halmos? do sections inherit from their parents? if so, what's the naming convention for section inheritance? |
|
||
depth = 1_000_000 | ||
storage-layout = 'generic' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps for the next pr: instead of having an example file here, it would be better to provide a running toml file in the test directories, under the examples/
and tests/
, where foundry.toml exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes!
almost but IMO it should be:
natspec feels more specific to a contract/function than the command line, which applies to the whole repo |
left for future work, currently there is a single supported but going forward I think it would be nice to support profiles, so you could have |
makes sense. that's also the existing behavior before this pr, right? actually i was wondering what if users want to quickly override the natspec options using command line, but that might not worth supporting. |
tests seem to become flaky. ci failed due to z3 model not found, and that also happened intermittently in my local:
|
I'm not happy with the hackiness and the flakiness, I'll close this one and put up something cleaner |
No description provided.