feat: --solver-command lets user replace z3 invocations #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes: - `--solver-subprocess` - `--solver-subprocess-command` - `--solver-fresh` (was unused AFAICT) This adds: - `--solver-command` with no default (meaning we run z3 in-process) - some prints about where SMT files are generated - auto-dumping of SMT files when invoking an external solver - a very crude way to determine if the external solver generated a valid model (instead of assuming it is valid, so that we still benefit from refinement) Before: ```sh $ halmos --root examples/simple --contract VaultTest --function check_mint -vvv --statistics [...] [FAIL] check_mint(uint256) (paths: 8, time: 282.15s (paths: 0.45s, models: 281.70s), bounds: []) ``` After: ```sh $ halmos --root examples/simple --contract VaultTest --function check_mint -vvv --statistics --solver-command="bitwuzla -m" [...] [FAIL] check_mint(uint256) (paths: 8, time: 19.69s (paths: 0.46s, models: 19.22s), bounds: []) ```
daejunpark
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes:
--solver-subprocess--solver-subprocess-command--solver-fresh(was unused AFAICT)This adds:
--solver-commandwith no default (meaning we run z3 in-process)Before:
After:
$ halmos --root examples/simple --contract VaultTest --function check_mint -vvv --statistics --solver-command="bitwuzla -m" [...] [FAIL] check_mint(uint256) (paths: 8, time: 19.69s (paths: 0.46s, models: 19.22s), bounds: [])