Skip to content

Commit

Permalink
change default in mk_copy (Draegerwerk#295)
Browse files Browse the repository at this point in the history
<!--- Provide a general summary of your changes in the title above -->
<!--- Link the corresponding issues after you created the pull request
-->

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [x] I have updated the [changelog](../CHANGELOG.md) accordingly.
- [ ] I have added tests to cover my changes.
  • Loading branch information
deichmab-draeger authored Nov 30, 2023
1 parent 7777eed commit 9bc4c03
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- basic_logging_setup only handles sdc logger, no more side effect due to calling logging.basicConfig.
- fixed wrong response for SetContextState message. [#287](https://github.com/Draegerwerk/sdc11073/issues/287
- fixed connection problem when provider closes socket after first request. [#289](https://github.com/Draegerwerk/sdc11073/issues/289

- change default in ContainerBase.mk_copy to not copy node due to performance problems. [#294](https://github.com/Draegerwerk/sdc11073/issues/294
-
### Changed
- change python classes of `addressing_types.py` to match ws-addressing standard of 2006 instead of 2004
- The final OperationInvokedReport has OperationTargetRef parameter set.
Expand Down
2 changes: 1 addition & 1 deletion src/sdc11073/mdib/containerbase.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def _update_from_other(self, other_container: ContainerBase, skipped_properties:
new_value = getattr(other_container, prop_name)
setattr(self, prop_name, copy.copy(new_value))

def mk_copy(self, copy_node: bool = True) -> ContainerBase:
def mk_copy(self, copy_node: bool = False) -> ContainerBase:
"""Make a copy of self."""
copied = copy.copy(self)
if copy_node and self.node is not None:
Expand Down

0 comments on commit 9bc4c03

Please sign in to comment.