-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: render cells that has no content but styles #182
Conversation
4efd715
to
a525733
Compare
Thank you for taking the time, creating this pr! On the surface this does make sense. |
I think the test failure is indeed caused by this PR but I don't know if my PR is wrong or the test snapshot is wrong. |
I believe the snapshot needs to be updated. The |
a525733
to
66fcd7b
Compare
Thanks for your explanation, I have updated the failing snapshot. |
66fcd7b
to
f3ce7a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, thank you for the contribution 👍 .
Hi, @a-kenji. Could you please publish a new release(or prerelease) for this fix? Thanks! |
@kxxt, |
Thanks a lot for your new release! I didn't get pinged but several days ago I found the bug magically disappeared, then I figured out that BTW there are some other issues regarding input with htop inside tui-term, which I am going to try to fix when I got more free time: kxxt/tracexec#11 |
Fix #181
I am not confident about this fix since I only briefly looked at the code base. So this PR should be reviewed carefully to avoid breaking other things.