Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check running jobs before feature generation job submission #528

Merged
merged 9 commits into from
Jan 10, 2024

Conversation

bfhealy
Copy link
Collaborator

@bfhealy bfhealy commented Jan 10, 2024

This PR modifies tools/generate_features_job_submission.py to count running jobs using squeue before submitting additional feature generation jobs. This allows each 48-hour run of the submission script to be run back-to-back with the next run (e.g. as a cron job), since the new instance of the script will have access to the current active job count.

The new code also makes more efficient use of real time by recognizing any failed jobs and queuing a new jobs to take their place. Previously any failures would restrict the max number of instances available for new jobs queued from the same script run. The user will still need to run another iteration of the script to re-run any failed jobs.

@bfhealy bfhealy temporarily deployed to Integrate Pull Request January 10, 2024 16:26 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request January 10, 2024 16:26 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request January 10, 2024 16:42 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request January 10, 2024 16:42 — with GitHub Actions Inactive
@bfhealy bfhealy had a problem deploying to Integrate Pull Request January 10, 2024 17:46 — with GitHub Actions Failure
@bfhealy bfhealy had a problem deploying to Integrate Pull Request January 10, 2024 17:46 — with GitHub Actions Failure
@bfhealy bfhealy had a problem deploying to Integrate Pull Request January 10, 2024 18:16 — with GitHub Actions Failure
@bfhealy bfhealy had a problem deploying to Integrate Pull Request January 10, 2024 18:16 — with GitHub Actions Failure
@bfhealy bfhealy temporarily deployed to Integrate Pull Request January 10, 2024 18:28 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request January 10, 2024 18:28 — with GitHub Actions Inactive
@bfhealy bfhealy had a problem deploying to Integrate Pull Request January 10, 2024 19:04 — with GitHub Actions Failure
@bfhealy bfhealy had a problem deploying to Integrate Pull Request January 10, 2024 19:04 — with GitHub Actions Failure
@bfhealy bfhealy temporarily deployed to Integrate Pull Request January 10, 2024 20:00 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request January 10, 2024 20:00 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request January 10, 2024 20:18 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request January 10, 2024 20:18 — with GitHub Actions Inactive
@bfhealy bfhealy changed the title WIP: Check running jobs before feature generation job submission Check running jobs before feature generation job submission Jan 10, 2024
@bfhealy bfhealy marked this pull request as ready for review January 10, 2024 20:51
@bfhealy bfhealy requested a review from mcoughlin January 10, 2024 20:51
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfhealy bfhealy merged commit 5ccd662 into ZwickyTransientFacility:main Jan 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants