-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check running jobs before feature generation job submission #528
Merged
bfhealy
merged 9 commits into
ZwickyTransientFacility:main
from
bfhealy:fg-count-running-jobs
Jan 10, 2024
Merged
Check running jobs before feature generation job submission #528
bfhealy
merged 9 commits into
ZwickyTransientFacility:main
from
bfhealy:fg-count-running-jobs
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfhealy
temporarily deployed
to
Integrate Pull Request
January 10, 2024 16:26 — with
GitHub Actions
Inactive
bfhealy
temporarily deployed
to
Integrate Pull Request
January 10, 2024 16:26 — with
GitHub Actions
Inactive
bfhealy
temporarily deployed
to
Integrate Pull Request
January 10, 2024 16:42 — with
GitHub Actions
Inactive
bfhealy
temporarily deployed
to
Integrate Pull Request
January 10, 2024 16:42 — with
GitHub Actions
Inactive
bfhealy
had a problem deploying
to
Integrate Pull Request
January 10, 2024 17:46 — with
GitHub Actions
Failure
bfhealy
had a problem deploying
to
Integrate Pull Request
January 10, 2024 17:46 — with
GitHub Actions
Failure
bfhealy
had a problem deploying
to
Integrate Pull Request
January 10, 2024 18:16 — with
GitHub Actions
Failure
bfhealy
had a problem deploying
to
Integrate Pull Request
January 10, 2024 18:16 — with
GitHub Actions
Failure
bfhealy
temporarily deployed
to
Integrate Pull Request
January 10, 2024 18:28 — with
GitHub Actions
Inactive
bfhealy
temporarily deployed
to
Integrate Pull Request
January 10, 2024 18:28 — with
GitHub Actions
Inactive
bfhealy
had a problem deploying
to
Integrate Pull Request
January 10, 2024 19:04 — with
GitHub Actions
Failure
bfhealy
had a problem deploying
to
Integrate Pull Request
January 10, 2024 19:04 — with
GitHub Actions
Failure
bfhealy
temporarily deployed
to
Integrate Pull Request
January 10, 2024 20:00 — with
GitHub Actions
Inactive
bfhealy
temporarily deployed
to
Integrate Pull Request
January 10, 2024 20:00 — with
GitHub Actions
Inactive
bfhealy
temporarily deployed
to
Integrate Pull Request
January 10, 2024 20:18 — with
GitHub Actions
Inactive
bfhealy
temporarily deployed
to
Integrate Pull Request
January 10, 2024 20:18 — with
GitHub Actions
Inactive
bfhealy
changed the title
WIP: Check running jobs before feature generation job submission
Check running jobs before feature generation job submission
Jan 10, 2024
mcoughlin
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
tools/generate_features_job_submission.py
to count running jobs usingsqueue
before submitting additional feature generation jobs. This allows each 48-hour run of the submission script to be run back-to-back with the next run (e.g. as a cron job), since the new instance of the script will have access to the current active job count.The new code also makes more efficient use of real time by recognizing any failed jobs and queuing a new jobs to take their place. Previously any failures would restrict the max number of instances available for new jobs queued from the same script run. The user will still need to run another iteration of the script to re-run any failed jobs.