Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow combine_preds.py to access config-specified fields #513

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

bfhealy
Copy link
Collaborator

@bfhealy bfhealy commented Dec 8, 2023

This PR allows tools/combine_preds.py to access the inference fields specified at the end of config.yaml by adding the --use_config_fields argument. Since we tend to run inference and then combine DNN/XGB predictions for the same subsets of fields at a time, this will make it easier to expand scope classification results without duplicating compute effort on completed fields.

@bfhealy bfhealy temporarily deployed to Integrate Pull Request December 8, 2023 18:42 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request December 8, 2023 18:42 — with GitHub Actions Inactive
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfhealy bfhealy merged commit ef148c7 into ZwickyTransientFacility:main Dec 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants