Add configurable time cutoff to mongoDB light curve query #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfhealy
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
bfhealy
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
bfhealy
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
bfhealy
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
bfhealy
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
bfhealy
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
mcoughlin
approved these changes
Nov 3, 2023
scope/fritz.py
Outdated
| @@ -187,6 +189,10 @@ def get_lightcurves_via_ids( | |||
| while True: | |||
| Nqueries = int(np.ceil(Nsources / limit_per_query)) | |||
|
|
|||
| time_filter = {"$gt": 0.0} | |||
| if cutoff_mjd is not None: | |||
| time_filter["$lte"] = 2400000.5 + cutoff_mjd | |||
There was a problem hiding this comment.
Maybe just add a comment to remind folks what units are being converted to here?
There was a problem hiding this comment.
I ended up modifying this code to avoid the conversion and instead require the full HJD in the config entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows all light curves queried from Kowalski to be truncated at a config-specified MJD. Note that since timestamps on Kowalski are measured in HJD, for any given source there is a coordinate-dependent discrepancy of ±8.3 mins between the two time units due to light travel time between the Earth/Sun. This should not be a major issue given that we later enforce a requirement that light curve points be spaced by no less than 30 minutes.