Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more path customization for feature generation/inference #493

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

bfhealy
Copy link
Collaborator

@bfhealy bfhealy commented Sep 27, 2023

SCoPe code typically references a single BASE_DIR that contains the code along with input and output data. This PR adds more flexibility by allowing users to specify a path_to_features in the config file other than the base SCoPe directory. If this path is given, the BASE_DIR variable will be redefined in feature generation code and results will be saved to the specified directory. This is useful for generating features on a cluster, where the code's installation directory may not be ideal for saving larger files.

Additionally, this PR makes use of the existing path_to_preds config entry to allow inference results to be saved in a directory other than the base code directory. Further testing will be done on Expanse to ensure the path updates work as intended.

(See also #488)

@bfhealy bfhealy temporarily deployed to Integrate Pull Request September 27, 2023 22:21 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request September 27, 2023 22:21 — with GitHub Actions Inactive
@bfhealy bfhealy had a problem deploying to Integrate Pull Request September 28, 2023 17:05 — with GitHub Actions Failure
@bfhealy bfhealy had a problem deploying to Integrate Pull Request September 28, 2023 17:05 — with GitHub Actions Failure
@bfhealy bfhealy temporarily deployed to Integrate Pull Request September 28, 2023 17:08 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request September 28, 2023 17:08 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request September 28, 2023 17:22 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request September 28, 2023 17:22 — with GitHub Actions Inactive
@bfhealy bfhealy marked this pull request as ready for review September 28, 2023 23:04
@bfhealy bfhealy requested a review from mcoughlin September 28, 2023 23:04
@bfhealy bfhealy changed the title WIP: allow more path customizability for feature generation/inference Allow more path customization for feature generation/inference Sep 28, 2023
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfhealy bfhealy merged commit 3ef9c54 into ZwickyTransientFacility:main Sep 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants