Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Fritz instrument_id request to upload script #489

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

bfhealy
Copy link
Collaborator

@bfhealy bfhealy commented Sep 14, 2023

This PR moves the instrument API request from fritz.py to scope_upload_classification.py. This avoids the automatic running of this request whenever code from fritz.py is imported, while allowing a new --instrument_name argument to be passed to scope_upload_classification.py.

@bfhealy bfhealy temporarily deployed to Integrate Pull Request September 14, 2023 16:11 — with GitHub Actions Inactive
@bfhealy bfhealy temporarily deployed to Integrate Pull Request September 14, 2023 16:11 — with GitHub Actions Inactive
@mcoughlin mcoughlin self-requested a review September 14, 2023 16:25
Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfhealy bfhealy merged commit 308c284 into ZwickyTransientFacility:main Sep 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants