Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting errors and refactor code #2243

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hasnainmohiuddin
Copy link

  • [✅] I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • [✅] I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • [✅] I have properly documented new or changed features in the documentation or in the docstrings
  • [✅] I have properly explained unusual or unexpected code in the comments around it

@Cokral
Copy link

Cokral commented Nov 20, 2024

I think the linting errors you are refering to were fixed already, as CI on master runs nicely.

Comment on lines +10 to +13
try:
import numpy as np
except ImportError as exc:
raise ImportError("MoviePy requires numpy. Please install it with pip install numpy") from exc
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the benefit of doing this? numpy, and other dependencies are clearly stated in the pyproject.toml file so I think adding this is overkill.

Maybe I am missing some other benefit?

@Zulko
Copy link
Owner

Zulko commented Nov 24, 2024

Looks like there is more than code refactoring and style linting in this MR. Maybe submit it as smaller MRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants