Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedded_scheduler -> olg_scheduler #3

Merged
merged 1 commit into from
Aug 23, 2024
Merged

embedded_scheduler -> olg_scheduler #3

merged 1 commit into from
Aug 23, 2024

Conversation

serges147
Copy link
Collaborator

No description provided.

@serges147 serges147 self-assigned this Aug 23, 2024
Copy link
Member

@pavel-kirienko pavel-kirienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool but since it's a single-file library it should be placed under include/olg_scheduler.hpp, so that you go like:

#include <olg_scheduler.hpp>

@serges147 serges147 merged commit b7cf105 into master Aug 23, 2024
14 checks passed
@serges147
Copy link
Collaborator Author

Cool but since it's a single-file library it should be placed under include/olg_scheduler.hpp, so that you go like:

#include <olg_scheduler.hpp>

I wasn't aware that there is such distinction - what I see is inconsistency. IMHO it's better to have single pattern - <library>/<header(s)>. Today it is one file, tomorrow it might be multiple...

@pavel-kirienko pavel-kirienko deleted the sshirokov/olg branch August 23, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants