Add _get_type_id to Impl

[maksimdrachov]

Summary by CodeRabbit

• New Features
  • Introduced a new method for type identification in the event handling framework, enhancing the functionality of the EventProxy class.

[coderabbitai]

Walkthrough

The changes introduce a new static method _get_type_id_() in the Event class, which returns a fixed-size array of hexadecimal values. This method is then exposed in the EventProxy class, allowing it to access the type ID functionality for event identification purposes. There are no modifications to existing logic or control flow in the code.

Changes

File	Change Summary
include/olg_scheduler/olg_scheduler.hpp	Added static method _get_type_id_() in Event class; exposed it in EventProxy class.

Poem

In the meadow where events do play,
A new ID hops in, brightening the day.
With a static method, swift and neat,
Type identification, oh what a treat!
EventProxy dances, with values in tow,
Hopping along, as the changes bestow! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 60b0d70 and 9ff67dd.

📒 Files selected for processing (1)

• include/olg_scheduler/olg_scheduler.hpp (5 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• include/olg_scheduler/olg_scheduler.hpp

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 4

🧹 Outside diff range and nitpick comments (1)

include/olg_scheduler/olg_scheduler.hpp (1)

100-104: Consider alternatives to custom RTTI implementation

The current implementation uses a manually maintained UUID for type identification, which could lead to:

1. Maintenance overhead in ensuring unique IDs across the codebase
2. No compile-time guarantee of uniqueness
3. Potential for collisions if IDs are manually assigned

Consider these alternatives:

1. Use built-in C++ RTTI with typeid and std::type_info if RTTI is enabled
2. Use boost::typeindex for a more robust type identification system that works even with RTTI disabled
3. If custom IDs are required, consider using a compile-time hash of the type name to ensure uniqueness

Would you like me to provide example implementations for any of these alternatives?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 306a574 and 60b0d70.

📒 Files selected for processing (1)

• include/olg_scheduler/olg_scheduler.hpp (5 hunks)