Skip to content

Commit

Permalink
fix: default compression to 'none' (open-telemetry#4985)
Browse files Browse the repository at this point in the history
  • Loading branch information
sjvans authored and Zirak committed Sep 14, 2024
1 parent a2c25d0 commit 12147ca
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ All notable changes to experimental packages in this project will be documented
### :bug: (Bug Fix)

* fix(sampler-jaeger-remote): fixes an issue where package could emit unhandled promise rejections @Just-Sieb
* fix(otlp-grpc-exporter-base): default compression to `'none'` if env vars `OTEL_EXPORTER_OTLP_TRACES_COMPRESSION` and `OTEL_EXPORTER_OTLP_COMPRESSION` are falsy @sjvans

### :books: (Refine Doc)

Expand Down
3 changes: 2 additions & 1 deletion experimental/packages/otlp-grpc-exporter-base/src/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ export function configureCompression(

const envCompression =
getEnv().OTEL_EXPORTER_OTLP_TRACES_COMPRESSION ||
getEnv().OTEL_EXPORTER_OTLP_COMPRESSION;
getEnv().OTEL_EXPORTER_OTLP_COMPRESSION ||
'none';

if (envCompression === 'gzip') {
return CompressionAlgorithm.GZIP;
Expand Down

0 comments on commit 12147ca

Please sign in to comment.