ZCS-11850:changed validation on volume apis #1374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupeshtelus
requested review from
zimsuchitgupta,
inpati,
RakeshAMore,
abhishekdeshmukh2209,
dasiyogesh,
gautamdg,
shrutig0510,
silentsakky,
vishnukantjangid and
wilfredo-alfaro-telus
zimsuchitgupta
approved these changes
Aug 18, 2022
store/src/java/com/zimbra/cs/service/util/VolumeConfigUtil.java
Outdated
Show resolved
Hide resolved
rupeshtelus
force-pushed
the
feature/ZCS-11850
branch
4 times, most recently
from
20d38b4 to
f37b4e7
Compare
silentsakky
reviewed
Aug 19, 2022
store/src/java/com/zimbra/cs/service/util/VolumeConfigUtil.java
Outdated
Show resolved
Hide resolved
silentsakky
reviewed
Aug 19, 2022
store/src/java/com/zimbra/cs/service/util/VolumeConfigUtil.java
Outdated
Show resolved
Hide resolved
silentsakky
reviewed
Aug 19, 2022
store/src/java/com/zimbra/cs/service/util/VolumeConfigUtil.java
Outdated
Show resolved
Hide resolved
silentsakky
reviewed
Aug 19, 2022
|
Please add ticket number in every commit message |
rupeshtelus
force-pushed
the
feature/ZCS-11850
branch
from
f37b4e7 to
5f21725
Compare
rupeshtelus
changed the title
rupeshtelus
force-pushed
the
feature/ZCS-11850
branch
2 times, most recently
from
d7b0e3a to
7863a78
Compare
RakeshAMore
reviewed
Aug 19, 2022
store/src/java/com/zimbra/cs/service/util/VolumeConfigUtil.java
Outdated
Show resolved
Hide resolved
RakeshAMore
approved these changes
Aug 19, 2022
rupeshtelus
force-pushed
the
feature/ZCS-11850
branch
2 times, most recently
from
cf827d1 to
efbcb62
Compare
RakeshAMore
requested changes
Aug 22, 2022
store/src/java/com/zimbra/cs/service/util/VolumeConfigUtil.java
Outdated
Show resolved
Hide resolved
rupeshtelus
force-pushed
the
feature/ZCS-11850
branch
from
efbcb62 to
572db4a
Compare
rupeshtelus
force-pushed
the
feature/ZCS-11850
branch
from
b9b0520 to
7187d46
Compare
rupeshtelus
commented
Aug 23, 2022
rupeshtelus
force-pushed
the
feature/ZCS-11850
branch
from
234a92d to
7444a21
Compare
RakeshAMore
approved these changes
Aug 23, 2022
rupeshtelus
force-pushed
the
feature/ZCS-11850
branch
4 times, most recently
from
26e0391 to
06ca18c
Compare
rupeshtelus
force-pushed
the
feature/ZCS-11850
branch
from
88236a8 to
ccf816b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Validations on Volume APIS
feature - https://jira.corp.synacor.com/browse/ZCS-11850
referred sheet - https://docs.google.com/spreadsheets/d/1mbQnEZ4BoZXxVGsJrgy-DDVJrLIfeRQu4gR75o8wdCA/edit#gid=0