Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/zcs 5928 #84

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Bugfix/zcs 5928 #84

wants to merge 4 commits into from

Conversation

srivastava-ami
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@fatkudu fatkudu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please think about how to make commit comments useful. In general, it is good to answer the question "Why" rather than the question "What".

@@ -53,6 +53,8 @@ override_dh_auto_install:
rm -f $$(pwd)/debian/tmpOZCL/libmysqlclient_r.so.18
rm -f $$(pwd)/debian/tmpOZCL/libmysqlclient_r.so.18.0.0
cd $$(pwd)/debian/tmpOZCL && \
ln -s libmariadb.so.3 libmysqlclient.so.18 && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include some evidence of the issue. The commit comment describes the fix not why it was done. What breaks if this is not done?

As an aside, it seems odd to have different versions on the shared libraries (but clearly if it is necessary, then fine)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was following with the MTA restart. I added it as a comment in ZCS-5928 already.

Starting saslauthd...done.
/opt/zimbra/common/sbin/postalias: error while loading shared libraries: libmysqlclient.so.18: cannot open shared object file: No
such file or directory
/opt/zimbra/common/sbin/postfix: error while loading shared libraries: libmysqlclient.so.18: cannot open shared object file: No such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants