Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump outdated evm_js_tests modules. #2018

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

saeed-zil
Copy link
Contributor

@saeed-zil saeed-zil commented Dec 15, 2024

  • Use pnpm instead of npm!
  • Remove web3.js dependency. (web3.js hardhat plugin is outdated and doesn't support the latest version of web3.js)
  • Remove useless tests.
  • Fix compilation errors.
  • Use a newer version of nodejs (18.20)

Copy link
Contributor

github-actions bot commented Dec 15, 2024

🐰 Bencher Report

Branchbump-evm-js-tests-modules-2
Testbedself-hosted
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
process-empty/process-empty📈 view plot
🚷 view threshold
9.59
(+4.53%)
10.41
(92.10%)
produce-full/produce-full📈 view plot
🚷 view threshold
1,957.30
(-5.23%)
2,714.35
(72.11%)
🐰 View full continuous benchmarking report in Bencher

@saeed-zil saeed-zil enabled auto-merge December 16, 2024 07:07
Copy link
Contributor

@JamesHinshelwood JamesHinshelwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

scripts/js_test.sh Outdated Show resolved Hide resolved
Co-authored-by: James Hinshelwood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants