Fix DifferentChainID error
#722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #699 attempted to remove the startup-time dependency on the API by moving the point at which we get the chain ID to transaction creation time. However, this wasn't valid because the signer needs to be configured with the correct chain ID. Instead, we wrap our provider in a `tokio::sync::OnceCell` and lazily initialise it. This means the signer is initialised with the result of the call from `eth_chainId`, but we don't need to make this call until someone uses the faucet.
chetan-zilliqa
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #699 attempted to remove the startup-time dependency on the API by moving the point at which we get the chain ID to transaction creation time.
However, this wasn't valid because the signer needs to be configured with the correct chain ID. Instead, we wrap our provider in a
tokio::sync::OnceCelland lazily initialise it.This means the signer is initialised with the result of the call from
eth_chainId, but we don't need to make this call until someone uses the faucet.