Fix sqlx compilation errors #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WuBruno
requested review from
troelsfr,
JamesHinshelwood and
rrw-zilliqa
as code owners
JamesHinshelwood
previously approved these changes
Oct 6, 2023
WuBruno
force-pushed
the
fix-sqlx-compilation
branch
from
1096086 to
ed7f45c
Compare
JamesHinshelwood
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @DronHazra, offline builds are currently not being supported because the
.sqlxfolder is not populated appropriately with the necessary data for the compiler to validate the query data types. Since I had a instance of fully populated local Postgres DB, I have used it to update the.sqlxfiles appropriately.What this means is that if you clone this repo and run:
cargo buildit should work seamlessly.https://zilliqa-team.slack.com/archives/C04D147S9QX/p1696515902983839?thread_ts=1696508639.985359&cid=C04D147S9QX