Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 8 and add support for direct staking of rewards #14

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

DrZoltanFazekas
Copy link
Contributor

@DrZoltanFazekas DrZoltanFazekas commented Nov 26, 2024

Fix issue 8 in the first place. Implement minor improvements such as the removal of the deposit.sol contract from the repo and support for direct staking as an alternative to withdrawal of rewards (non-staking variant).

@DrZoltanFazekas DrZoltanFazekas enabled auto-merge (squash) November 26, 2024 14:07
@DrZoltanFazekas DrZoltanFazekas changed the title Additional fixes and support for direct staking of rewards Fix issue 8 and add support for direct staking of rewards Nov 26, 2024
Copy link

@86667 86667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for some of the nice fixes in here. I hope we get chance to review the code with the intention to simplify and make clearer some parts before we send it off for audit.

eg:

src/NonLiquidDelegationV2.sol Show resolved Hide resolved
@DrZoltanFazekas DrZoltanFazekas merged commit 69d9ba4 into main Nov 29, 2024
2 checks passed
@DrZoltanFazekas DrZoltanFazekas deleted the fix-issue-8 branch November 29, 2024 08:18
DrZoltanFazekas added a commit that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rewards() doesn't reflect withdrawRewards() Implement staking of NonLiquidDelegation rewards
2 participants