[WIP] add dynamic type and weight support #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will review ASAP, thanks for your contribution. |
|
We have encountered the same issue with this "weight support." The proposed solution above is acceptable. Please handle promptly. Thank you. @zhgchgli0718 |
|
I have adjusted the tests and the AppKit. If there are no issues, we can proceed with merging and releasing it. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey this is WIP, to gather feedback.
This add support for weights in addition to bold and enable dynamic type.
Tests won't passe due to dynamic type changing the font size, I'm wondering if this should be toggle-able and a separate property of the MarkupStyleFont.
AppKit part is not updated yet.