Pes 2155 phpstan lvl 2

Packetery/Checkout/Controller/Adminhtml/Order/Detail.php

@@ -66,6 +66,7 @@ public function execute(): AbstractResult
             return $this->resultRedirectFactory->create()->setPath('*/*/index');
         }
 
+        /** @var \Magento\Framework\View\Element\AbstractBlock $addressDetailBlock */
         $addressDetailBlock = $resultPage->getLayout()->getBlock('packetery_order_address_detail');
         $addressDetailBlock->setData('order', $order);
         $addressDetailBlock->setData('magentoOrder', $magentoOrder);

Packetery/Checkout/Model/Carrier/AbstractCarrier.php

@@ -38,6 +38,14 @@ public function __construct(
         $this->packeteryConfig = $brain->createConfig($this);
     }
 
+    /**
+     * @return mixed
+     */
+    public function getStore()
+    {
+        return parent::getStore();
+    }
+
     /**
      * {@inheritdoc}
      */

Packetery/Checkout/Model/Carrier/Imp/PacketeryPacketaDynamic/Brain.php

@@ -78,7 +78,7 @@ public function isAssignableToPricingRule(): bool
 
     /**
      * @param int|null $dynamicCarrierId
-     * @return \Packetery\Checkout\Model\Carrier|null
+     * @return \Packetery\Checkout\Model\Carrier\Imp\PacketeryPacketaDynamic\DynamicCarrier|null
      */
     public function getDynamicCarrierById(?int $dynamicCarrierId): ?AbstractDynamicCarrier
     {

Packetery/Checkout/Model/ResourceModel/Order/Collection.php

@@ -18,6 +18,14 @@ protected function _construct()
         $this->_init('Packetery\Checkout\Model\Order', 'Packetery\Checkout\Model\ResourceModel\Order');
     }
 
+    /**
+     * @return \Packetery\Checkout\Model\Order[]
+     */
+    public function getItems()
+    {
+        return parent::getItems();
+    }
+
     /**
      * @return string
      */

Packetery/Checkout/Model/ResourceModel/PricingruleRepository.php

@@ -203,9 +203,11 @@ public function savePricingRule(array $postData, array $weightRules): \Packetery
      */
     public function setPricingRuleEnabled(int $id, bool $enabled): void
     {
-        $rule = $this->pricingRuleCollectionFactory->create()->getItemById($id);
-        $rule->setData('enabled', $enabled);
-        $rule->save();
+        /** @var \Packetery\Checkout\Model\ResourceModel\Pricingrule\Collection $collection */
+        $collection = $this->pricingRuleCollectionFactory->create();
+        $collection->addFilter('id', $id);
+        $collection->setDataToAll('enabled', $enabled);
+        $collection->save();
     }
 
     /**

Packetery/Checkout/Model/Weight/Calculator.php

@@ -32,18 +32,15 @@ public function getItemsWeight(array $allVisibleItems): float
 
         foreach ($allVisibleItems as $item) {
             if ($item->getProductType() === 'configurable') {
-                /** @var \Magento\Catalog\Model\Product $configurableProduct */
                 $configurableProduct = $item->getProduct();
                 if ($configurableProduct->isVirtual()) {
                     $configurableWeight = 0.0;
                 } else {
                     $configurableWeight = $configurableProduct->getWeight();
                 }
 
-                /** @var Item[] $children */
                 $children = ($item->getChildren() ?: []); // contains only ordered items
                 foreach ($children as $child) {
-                    /** @var \Magento\Catalog\Model\Product $childProduct */
                     $childProduct = $child->getProduct();
                     if ($childProduct->isVirtual()) {
                         $productWeights[$childProduct->getId()] = 0.0;
@@ -62,7 +59,6 @@ public function getItemsWeight(array $allVisibleItems): float
         }
 
         foreach ($allVisibleItems as $item) {
-            /** @var \Magento\Catalog\Model\Product $product */
             $product = $item->getProduct();
             if ($item->getProductType() === 'simple' && !array_key_exists($product->getId(), $productWeights)) {
                 if ($product->isVirtual()) {

Packetery/Checkout/Model/Weight/Item.php

@@ -66,4 +66,36 @@ public static function fromOrderItem(\Magento\Sales\Model\Order\Item $item): sel
 
         return $instance;
     }
+
+    /**
+     * @return string
+     */
+    public function getProductType()
+    {
+        return parent::getProductType();
+    }
+
+    /**
+     * @return self[]
+     */
+    public function getChildren()
+    {
+        return $this->getData('children');
+    }
+
+    /**
+     * @return int
+     */
+    public function getQty()
+    {
+        return $this->getData('qty');
+    }
+
+    /**
+     * @return \Magento\Catalog\Model\Product
+     */
+    public function getProduct()
+    {
+        return $this->getData('product');
+    }
 }

Packetery/Checkout/Observer/Sales/AddressPlaceAfter.php

@@ -29,6 +29,7 @@ public function execute(
         \Magento\Framework\Event\Observer $observer
     ) {
         $orderId = $observer->getData('order_id');
+        /** @var \Magento\Sales\Model\Order $order */
         $order = $this->orderRepository->get($orderId);
         $orderNumber = $order->getIncrementId();
         $shippingAddress = $order->getShippingAddress();

Packetery/Checkout/Observer/Sales/EmailOrderTemplateVarsBefore.php

@@ -37,8 +37,8 @@ public function execute(\Magento\Framework\Event\Observer $observer)
         $order = $transport['order'];
         $collection = $this->orderCollectionFactory->create();
         $collection->addFilter('order_number', $order->getData('increment_id'));
-        /** @var \Packetery\Checkout\Model\Order|null $packeteryOrder */
         $items = ( $collection->getItems() ?: [] );
+        /** @var \Packetery\Checkout\Model\Order|null $packeteryOrder */
         $packeteryOrder = array_shift($items);
 
         $transport['packetery_is_pickup_point'] = false;

Packetery/Checkout/view/adminhtml/templates/order-address-detail.phtml

@@ -1,5 +1,5 @@
 <?php
-/** @var \Packetery\Checkout\Block\Adminhtml\Order\AddressDetail $block */
+/** @var \Magento\Framework\View\Element\AbstractBlock $block */
 /** @var \Packetery\Checkout\Model\Order $packeteryOrder */
 $packeteryOrder = $block->getData('order');
 $packeteryMagentoOrder = $block->getData('magentoOrder');

phpstan-config.neon

@@ -1,9 +1,12 @@
 parameters:
     bootstrapFiles:
         - phpstan-autoload.php
-    level: 1
+    level: 2
     fileExtensions:
         - php
         - phtml
     paths:
         - ./Packetery/Checkout
+    ignoreErrors:
+        - '#Call to an undefined method Magento\\(.*)+\(\)\.#' # It is typical for Magento related code to use PHP magic.
+        - '#Call to an undefined static method Magento\\(.*)+\(\)\.#'