fix(notional-finance-v3): Fix supply and borrow position key (#3093)

Zapper-fi · Nov 29, 2023 · 5000792 · 5000792
1 parent afccc62
commit 5000792
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/...apps/notional-finance-v3/arbitrum/notional-finance-v3.borrow.contract-position-fetcher.ts b/...apps/notional-finance-v3/arbitrum/notional-finance-v3.borrow.contract-position-fetcher.ts
@@ -23,6 +23,7 @@ export type NotionalBorrowingDefinition = {
   underlyingTokenAddress: string;
   currencyId: number;
   tokenId: string;
+  fCashPV: number;
   maturity: number;
   type: string;
 };
@@ -120,8 +121,9 @@ export class ArbitrumNotionalFinanceV3BorrowContractPositionFetcher extends Cont
     params: GetDataPropsParams<NotionalView, NotionalBorrowingDataProps, NotionalBorrowingDefinition>,
   ) {
     const defaultDataProps = await super.getDataProps(params);
-    const props = pick(params.definition, ['currencyId', 'tokenId', 'maturity', 'fCashPV', 'type']);
-    return { ...defaultDataProps, ...props, positionKey: Object.values(props).join(':') };
+    const props = pick(params.definition, ['currencyId', 'tokenId', 'maturity', 'type']);
+    const fCashPV = params.definition.fCashPV;
+    return { ...defaultDataProps, ...props, fCashPV, positionKey: Object.values(props).join(':') };
   }
 
   async getLabel({ contractPosition }: GetDisplayPropsParams<NotionalView>): Promise<string> {

diff --git a/...apps/notional-finance-v3/arbitrum/notional-finance-v3.supply.contract-position-fetcher.ts b/...apps/notional-finance-v3/arbitrum/notional-finance-v3.supply.contract-position-fetcher.ts
@@ -24,6 +24,7 @@ export type NotionalFinanceLendingDefinition = {
   underlyingTokenAddress: string;
   currencyId: number;
   tokenId: string;
+  fCashPV: number;
   maturity: number;
   type: string;
 };
@@ -119,8 +120,9 @@ export class ArbitrumNotionalFinanceV3SupplyContractPositionFetcher extends Cont
     params: GetDataPropsParams<NotionalView, NotionalFinanceLendingDataProps, NotionalFinanceLendingDefinition>,
   ) {
     const defaultDataProps = await super.getDataProps(params);
-    const props = pick(params.definition, ['currencyId', 'tokenId', 'maturity', 'fCashPV', 'type']);
-    return { ...defaultDataProps, ...props, positionKey: Object.values(props).join(':') };
+    const props = pick(params.definition, ['currencyId', 'tokenId', 'maturity', 'type']);
+    const fCashPV = params.definition.fCashPV;
+    return { ...defaultDataProps, ...props, fCashPV, positionKey: Object.values(props).join(':') };
   }
 
   async getLabel({ contractPosition }: GetDisplayPropsParams<NotionalView>): Promise<string> {