-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISS: Refactor sidebar menu #631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good...QAing
When on the "Training Information" page, the sidebar won't expand Also, it was intentional to leave the sidebar expanded by default when on a page that exists in the sidebar so the user would have a queue of the page they're on and where that stands in the layout. Do we want to add this back? |
Thanks @iccowan - I somehow missed that. Will update this to include that as a feature. @c0repwn3r noted some issues with dark mode that also require a refactor on this, so I'll sort this out soon. |
Fixed sidebar so it remains open with the menu option selected on 9/6. |
We're not going to fix the zero-space problem in this PR. #645 created to capture this as a separate issue. |
I corrected the issue with the training information view - it was a class name conflict |
Before merging, just note my comment from discord: "I'm gonna go ahead and approve this, but one small CSS change that I noticed. When hovering over "ZTL Controllers", "Training", or "Administration", the cursor has the typing one instead of the finger. Once that's changed back it looks good!" |
This PR will: