Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero-space created by expanding sidebar menu #645

Open
1 task
kjporter opened this issue Sep 7, 2024 · 0 comments
Open
1 task

Fix zero-space created by expanding sidebar menu #645

kjporter opened this issue Sep 7, 2024 · 0 comments
Labels
Approved by WM This project is approved - work may begin now bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@kjporter
Copy link
Contributor

kjporter commented Sep 7, 2024

Description
When the sidebar menu expands, zero-space is created that bumps the visible elements outside of the parent body and html elements that are supposed to contain them. Here is the description of the issue from @c0repwn3r: If you have time, do you think you could refactor it further to remove the code that directly sets height and min-height? The reason I ask, is that for darkmode, the current implementation of the sidebar makes darkmode impossible to implement. By overriding height and min-height, the sidebar "pushes" the element out of the way to make room for itself - this results in there being a block directly below the sidebar where you can see directly through to the background rendered behind the page by the browser. I've taken a screenshot from a custom build of Firefox where I overrode this to #000 so you can see the issue - but every modern browser uses #fff here, so in dark mode, there would be a big ugly white block that we cannot get rid of in CSS since you can't style the emptiness where there is no page, if that makes sense
It's very weird behavior and not at all what the html/css spec says should happen, but this is what every modern browser does (tested with up-to-date versions of chromium, gecko, and webkit)
image

Acceptance Criteria

  • Sidebar menu expands while remaining contained within parent body and html elements

Accepted By:

Dev Notes

XD Notes

Working Branch

PR

Feature Toggle

QA Notes

Deployment Notes

@kjporter kjporter added bug Something isn't working Approved by WM This project is approved - work may begin now labels Sep 7, 2024
@kjporter kjporter added this to the Dark Mode milestone Sep 7, 2024
@kjporter kjporter added the help wanted Extra attention is needed label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by WM This project is approved - work may begin now bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant