forked from EvanOxfeld/node-unzip
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for @aws-sdk version 3 #325
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c0493dd
Add support for @aws-sdk version 3
alice-was-here b71f8b0
Address PR comments
alice-was-here 5d05b72
Revert "Address PR comments"
alice-was-here 3927030
Add node16 + tests, make import conditional, revert formatting changes
alice-was-here 2828d20
CI fixes
alice-was-here 1afcab3
Remove peer dep and tweak coverage
alice-was-here File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
const test = require("tap").test; | ||
const unzip = require("../unzip"); | ||
|
||
const version = +process.version.replace("v", "").split(".")[0]; | ||
|
||
test( | ||
"get content of a single file entry out of a zip", | ||
{ skip: version < 16 }, | ||
function (t) { | ||
const { S3Client } = require("@aws-sdk/client-s3"); | ||
|
||
const client = new S3Client({ | ||
region: "us-east-1", | ||
signer: { sign: async (request) => request }, | ||
}); | ||
|
||
// These files are provided by AWS's open data registry project. | ||
// https://github.com/awslabs/open-data-registry | ||
|
||
return unzip.Open.s3_v3(client, { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If there's a better file source for this I can change it. The one referenced by the |
||
Bucket: "wikisum", | ||
Key: "WikiSumDataset.zip", | ||
}).then(function (d) { | ||
const file = d.files.filter(function (file) { | ||
return file.path == "WikiSumDataset/LICENSE.txt"; | ||
})[0]; | ||
|
||
return file.buffer().then(function (b) { | ||
const firstLine = b.toString().split("\n")[0]; | ||
t.equal(firstLine, "Attribution-NonCommercial-ShareAlike 3.0 Unported"); | ||
t.end(); | ||
}); | ||
}); | ||
} | ||
); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping the tap cli was required to correctly import the aws libraries (they include
??
and other syntax not supported by tap@12).The coverage report also seems to compute differently for tap 16 - I've
disabledreduced it to make the test suite pass.... it was computing coverage at about 80% even though nothing else had changed. If anyone has ideas as to why it dropped off, happy to add back?