Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak KEX/Unity order in IWAD selection box to be consistent across games #2772

Closed
wants to merge 1 commit into from
Closed

Tweak KEX/Unity order in IWAD selection box to be consistent across games #2772

wants to merge 1 commit into from

Conversation

Calinou
Copy link
Contributor

@Calinou Calinou commented Oct 19, 2024

@Calinou
Tweak KEX/Unity order in IWAD selection box to be consistent across g…
2fe1e7c 
…ames

- Fix missing space in "Hacx: Twitch 'n Kill".
  - The official capitalization seems a bit inconsistent with "HacX" being
    regularly used by its original developers, but the Doom wiki uses "Hacx".
@madame-rachelle
Copy link
Collaborator

Er, What consistency is this adhering to?

madame-rachelle
madame-rachelle requested changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@madame-rachelle madame-rachelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in the main thread

@coelckers
Copy link
Member

coelckers commented Oct 19, 2024 •
edited
Loading

Er, What consistency is this adhering to?

Is this so hard to see? For the Final Doom WADs, KEX comes beforeUnity, but for Doom 1 and 2 it comes after.

@madame-rachelle
Copy link
Collaborator

I don't like this order. The Kex edition came after the Unity editions did, so I will handle this myself.

The original came from an external contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madame-rachelle madame-rachelle madame-rachelle requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @madame-rachelle @coelckers