Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system for modular SBARINFO #2742

Merged
merged 5 commits into from
Nov 24, 2024
Merged

Conversation

BinarryCode
Copy link
Contributor

@BinarryCode BinarryCode commented Oct 3, 2024

Doing this to keep parity with a Zandronum patch request.

  • Added new top level "AppendStatusBar", allowing for extra SBARINFO code to be added to custom SBARINFO definitions.

…INFO code to be added to custom SBARINFO definitions.
@MajorCooke
Copy link
Contributor

MajorCooke commented Oct 3, 2024

Is this what I think it is? So this would allow attaching multiple status bars on top of each other?

I hope some day we can make it so multiple ZScript statusbars can be run at once.

@MrRaveYard
Copy link
Contributor

This seems to be "I don't want to copy+paste the entire SBARINFO just to add one thing to the screen" solution.

@RicardoLuis0
Copy link
Collaborator

This seems to be "I don't want to copy+paste the entire SBARINFO just to add one thing to the screen" solution.

nah, pretty sure this is for addon mods that don't replace custom huds, being for zandro and all

@prof-hastig
Copy link
Contributor

and so a supposedly deprecated feature continues to live on...

src/g_statusbar/sbarinfo.cpp Outdated Show resolved Hide resolved
@RicardoLuis0
Copy link
Collaborator

and so a supposedly deprecated feature continues to live on...

if such feature is extended in other ports, the least we can do is keep parity

@BinarryCode
Copy link
Contributor Author

Any progress on this? Zandro devs are currently waiting on if it gets merged or not.

Update code to be consistent with patch for Zandronum
@BinarryCode
Copy link
Contributor Author

There is another implementation Kaminsky wants used so it's easier to transplant, made it use that in the current commit - I can revert if needed.

@RicardoLuis0
Copy link
Collaborator

Any progress on this? Zandro devs are currently waiting on if it gets merged or not.

SBARINFO is not actively developed for gzdoom -- it'll only be merged for compat if the feature lands on zandro

@BinarryCode
Copy link
Contributor Author

@RicardoLuis0
Copy link
Collaborator

just waiting on CI to run 👍

@RicardoLuis0 RicardoLuis0 merged commit 5576e66 into ZDoom:master Nov 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants