Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Update to latest versions #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AidanWarner97
Copy link

This updates the Plex version to 1.30.0.6486 (current as of today)

Also updates the NGINX Proxy to work with PHP8.1 instead of deprecated PHP5

Update to latest version of plex and require latest version of YunoHost 11
Make use of PHP 8.1 instead of deprecated PHP 5
This reverts commit 9c20cb0.
Copy link

@jphastings jphastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me; I’d like to be able to use it on my server, is there anything blocking a merge?

@AidanWarner97
Copy link
Author

This looks great to me; I’d like to be able to use it on my server, is there anything blocking a merge?

Nope, nothing blocking a merge. I've been using it personally for a while now

@jphastings
Copy link

@AidanWarner97 nice! Looking at your Pr for reasons why it may not have been merged yet:

  • Did you intend to replace the current maintainer with yourself?
  • Did you intend to remove the French translations of the descriptions? (Yunohost looks to be at least bilingual in almost all the official places, I don’t think you’d need any differences to the descriptions in origin/master, so re-adding them may help)

Otherwise I hope the current maintainer will be comfortable with merging soon!

@AidanWarner97
Copy link
Author

@jphastings I'd be happy to take over maintainership of this repo to keep it up to date with newer versions.
I removed the French translations as I was expecting to change a few strings so the translations wouldn't have been accurate. However, I didn't end up changing them, so I need to just revert the removal and add them back in.

@jphastings
Copy link

Awesome! @liberodark, would you be interested in letting @AidanWarner97 help maintain this repo?

@jphastings
Copy link

Hey @AidanWarner97, I've been testing your fork on my YunoHost instance and I'm unable to connect to it from outside my local network.

I'm struggling to find the cause at the moment; I'm not so familiar with YunoHost app setup, but the setup script seems to "pick" a port for plex, but I believe plex requires that (at least locally) it is present on 32400. Could this be an issue fixable in your PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants