Flutter engine group #133
Open
Flutter engine group #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yukams This should be 2.0.6-dev.3 and later on merged into master. I'm happy to take over merging and looking into other pending PRs / publishing if you're busy, just take a look at it first please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes pushing complex objects as-is to isolates via ports:
flutter/flutter#152484 (comment)
While it's true that you can send only simple objects (int, double, String ... and ports themselves) through ports, it's also true that for isolates that were created from the main isolate, you can send complex immutable objects via automatic deep copy as well, which resolves the need for serialization (and deserialization) and also makes transfer a lot faster.
Because isolate in background locator is started from a foreground service, you can't do complex objects transfer unless you initialize FlutterEngine within the same FlutterEngineGroup. This PR does exactly that.